Repository navigation
Conversation
stonebuzz
marked this pull request as draft
October 19, 2026 12:26
stonebuzz
marked this pull request as ready for review
October 19, 2026 12:36
Rom1-B
reviewed
Oct 19, 2026
Rom1-B
left a comment
Rom1-B
left a comment
Contributor
There was a problem hiding this comment.
IpAddressQuestionandHostnameQuestion` also compute their value server-side; should they be allowed for unauthenticated access too?
Contributor
Author
|
Need backport for GLPI 11 |
stonebuzz
force-pushed
the
fix_hidden_field
branch
2 times, most recently
from
October 20, 2026 07:29
0ce1baf to
42d57cf
Compare
Herafia
approved these changes
Oct 20, 2026
Herafia
left a comment
Herafia
left a comment
There was a problem hiding this comment.
@stonebuzz solveAltchaChallenge is copied from SubmitAnswerControllerTest in the core. If more tests are added, it might be better to move it to AdvancedFormsTestCase or a trait. We can also do that later. ;)
4 tasks
stonebuzz
force-pushed
the
fix_hidden_field
branch
from
October 20, 2026 13:33
42d57cf to
d742982
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
The hidden question type kept the default behavior of AbstractQuestionType,
which excludes it from forms answered without authentication. As a result,
every hidden question was dropped from anonymous forms and its value was
never saved.
The submitted value is never used: prepareEndUserAnswer() always returns the
configured default value, so the type can be enabled for anonymous forms.
Screenshots (if appropriate):